-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Upgrade to google.golang.org/grpc v1.66.2 #9401
Draft
aknuds1
wants to merge
7
commits into
main
Choose a base branch
from
arve/upgrade-grpc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aknuds1
requested review from
stevesg,
grafanabot and
a team
as code owners
September 25, 2024 07:54
aknuds1
force-pushed
the
arve/upgrade-grpc
branch
from
September 25, 2024 07:55
06c9166
to
c6b77ea
Compare
Some tests are breaking for this upgrade, have to fix them. |
aknuds1
force-pushed
the
arve/upgrade-grpc
branch
from
September 25, 2024 10:57
7ed1789
to
b61cbbd
Compare
aknuds1
changed the title
Upgrade to google.golang.org/grpc v1.66.2
WIP: Upgrade to google.golang.org/grpc v1.66.2
Sep 25, 2024
Tests currently pass, but that is through undoing some memory unsafe optimizations in the |
aknuds1
force-pushed
the
arve/upgrade-grpc
branch
16 times, most recently
from
September 30, 2024 11:45
d79ea9f
to
f484e3a
Compare
aknuds1
force-pushed
the
arve/upgrade-grpc
branch
10 times, most recently
from
October 1, 2024 15:55
65b81e5
to
61a0b97
Compare
Also upgrade github.com/googleapis/enterprise-certificate-proxy to v0.3.4, to fix a checksum issue in v0.3.3. Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
Signed-off-by: Arve Knudsen <[email protected]>
aknuds1
force-pushed
the
arve/upgrade-grpc
branch
from
October 3, 2024 07:54
61a0b97
to
5b86337
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Upgrade google.golang.org/grpc from v1.65.0 to v1.66.2. The performance regression referenced from dskit's reversal to v1.65.0 is fixed in v1.66.2, and the potential functional regression also referenced in said reversal is Loki specific.
What we found out is that v1.66 fixes a serious performance bottleneck in conjunction with compression; the
decompress
function is optimized through memory pooling, whereas v1.65.0 would useio.ReadAll
and cause a lot of allocations during decompression. As a result, we saw ingester CPU usage increase by ~40% when enabling gRPC compression. The increase is now much more modest, maybe ~7% based on observations.Also upgrade github.com/googleapis/enterprise-certificate-proxy to v0.3.4, to fix a checksum issue in v0.3.3 (v0.3.4 was released to take care of this). With v0.3.3, building on OS X fails:
Which issue(s) this PR fixes or relates to
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
.about-versioning.md
updated with experimental features.